How to make enemies destroyed help

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

coding-culture

I made a game where you can hit enemies, Ive programmed that if they would touch the sword hitbox they would be destroyed. Now the problem is that if the player hits one, all enemies get deleted and i dont want that.

mangis

To properly answer, knowing a bit more about your implementation details would help.

I assume you're using signals and connect the body_entered signal of your sword to each enemy. In this case you should instead connect the body_entered signal of each enemy to that enemy itself.

class_name Enemy

func _init():
	connect("body_entered", self, "_body_entered")

func _body_entered(body):
	if body is Sword:
		queue_free()

coding-culture

@mangis i have a signal called "hit". It gets emmited when you press attack and the hit region detects something. As i sayed, i connected the signal with the enemy, then i duplicated the enemy node

fire7side

@"coding culture" said: . As i sayed, i connected the signal with the enemy, then i duplicated the enemy node

That's why it's not working, every enemy is listening for that signal. You have to just get the body entered signal from the enemy and apply it to the enemy like his code shows. That might mean adding an area node to the enemy, though, if it's a kinematic. I'm not sure on that.

coding-culture

@fire7side the problem is now solved. Everytime the signal hit gets emmitted the enemie checks if his colllisionshape is entered, if yes it deletes itself. But i still have one question: i just struggled with connecting the hit signal by code with another scene, because everybody writes like connect(signal, self, function_name()), but is it possible to connect a signal by script from a scene to another? I just tried different things but they all dont work. (Btw sorry for my dumb questions)

DaveTheCoder

You can do this:

a.connect("my_signal", b, "on_my_signal")

"a" is the node that emits the signal "my_signal", and "b" is the node whose script contains the signal handler method on_my_signal().

That statement can be anywhere in the scene tree, as long as "a" and "b" are valid references to nodes in the scene tree. My preference is to place the statement in the _ready() method of a node that's a common parent of "a" and "b", to ensure that "a" and "b" have been added to the scene tree.

fire7side

There's a little longer explanation here that might help for what DaveTheCoder went over: https://kidscancode.org/godot_recipes/basics/node_communication/ You can also name the signal and use the editor to connect to another script, which is the easiest. Once you name the signal, it will appear in the node tab. You just click on it and pick the script and it writes a function for you and does the connection.

coding-culture

@DaveTheCoder i know what you mean but my problem is that the scene which i want to be connected isnt in the scene. So how can i connect it? I thought that it will go with the following code:

var enemy = "res://Enemy.tscn"

func ready():
    self.connect(signal, enemy, signalname())

DaveTheCoder

the scene which i want to be connected isn't in the scene

I don't understand that.

coding-culture

@DaveTheCoder i mean if i have a game where random enemys spawn, i cant connect the signals by hand because the enemy isnt in the scene and just gets loaded after a time. I wanted to do it with get_node() but it doesnt works because the enemy node isnt in the scene and i dont know where to see a node path from a node.

coding-culture

@fire7side but how to connect to another script?

fire7side

If you use the editor, the node has to be in the scene already. You should be able to connect with code after it's spawned. You have to add it to the scene first, so you would need an add_child(enemy) before you can connect. I haven't done this, btw.

Pefistep

If you are creating the enemies in code, you can connect the signal in the same code where you are instantiating the new enemy. Something like this:

var enemy = load("res://Enemy.tscn")

func create_enemy():
	new_enemy = enemy.instance()
	add_child(new_enemy)
	self.connect("signal", new_enemy, "signal_handler")