My Camera2D limits system doesn't actually limit anything

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

My Camera2D limits system doesn't actually limit anything

taiyo-pixels

Hey all Taiyo here. Today I was making a Camera2D system similar to this (skip to around 5:52 ish).

This System uses a tilemap instancer similar to here.

Unlike the first link this system doesn't actually limit the camera like it's supposed to.

For those who might ask the section border doesn't have a script file.

My Camera2D does though. Here it is:

extends Camera2D


#Declare member variables here. Examples:

export onready var leftbound = get_node("/root/boundaries/LeftBoundaries")
export onready var rightbound = get_node("/root/boundaries/RightBoundaries")
export onready var topbound = get_node("/root/boundaries/TopBoundaries")
export onready var bottombound = get_node("/root/boundaries/BottomBoundaries")

onready var player = get_node("res://Scenes/Player.tscn")

#get_node("/root/Scenes/Player")
#res://Scenes/Player.tscn



# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.


#_boundaries
#_boundary, left_boundary, right_boundary,bottom_boundary,top_boundary
#body.is_in_group()

# Called every frame. 'delta' is the elapsed time since the previous frame.
#func _process(delta):
#	pass


#func _on_Area2D_body_entered(body):
	print("he's in!")
	if body.is_in_group("left_boundary"):
		limit_left = leftbound.position.x
	if body.is_in_group("right_boundary"):
		limit_right = rightbound.position.x
	if body.is_in_group("top_boundary"):
		limit_top = topbound.position.y
	if body.is_in_group("bottom_boundary"):
		limit_bottom = bottombound.position.y
	


#if body.is_in_group("boundaries"):
	#if body.is_in_group("left_boundary"):
		#limit_left = leftbound.position.x
	#elif body.is_in_group("right_boundary"):
		#limit_right = rightbound.position.x
	#elif body.is_in_group("top_boundary"):
		#limit_top = topbound.position.y
	#elif body.is_in_group("bottom_boundary"):
		#limit_bottom = bottombound.position.y

Please help

TwistedTwigleg

I would try using global_position instead of position properties and see if that works. The position property is the position of the Node2D node relative to it's parent, but global_position is relative to the origin of the scene, which is what I think you'll need for setting the camera limits.

taiyo-pixels

I'll see your advice and check back in

taiyo-pixels

Some bad news. It doesn't actually work. I tried moving the limits bounds around and it doesn't work.

Also I might've forgot to say the borders are actually Area2Ds

taiyo-pixels

However I did find this image from my terminal to be quite interesting

TwistedTwigleg

Hmm, maybe that is the issue. It seems it cannot get the nodes for the bounds. What might be happening is that, because it cannot get the node, it is instead assigning all the limits to 0, leading to nothing happening.

If you can assign the boundaries in the editor, what I would recommend doing is using some exported NodePath properties:

# make sure to set these in the editor through the inspector
export (NodePath) var leftbound_path
export (NodePath) var rightbound_path
export (NodePath) var topbound_path
export (NodePath) var bottombound_path

var leftbound
var rightbound
var topbound
var bottombound

func _ready():
	leftbound = get_node(leftbound_path)
	rightbound = get_node(rightbound_path)
	topbound = get_node(topbound_path)
	bottombound = get_node(bottombound_path)

Then you can set the NodePath values in the editor and they should be relative to the node, which I believe will fix the issue.

taiyo-pixels

NodePath Values aren't in the Camera2D as they are separate scenes.

Also it isn't really setting the values to 0 but it does nothing.

The right limit is at 100,000,000 pixels (default) and it doesn't change with or without the bounds

cybereality

That seems like an overly complex way of checking a rectangle. Better to use a Rect2 and has_point().

var bounds = Rect2(0, 0, 1920, 1080)

if not bounds.has_point(position):
   print("out of bounds")

taiyo-pixels

Where would the if statement be?

The process function or the area2d body entered/exited?

taiyo-pixels

4 days later I've decided to settle for the 2d Camera Limiter addon it basically sorta answers my question. Until I create my own system

cybereality

Sorry, I didn't see your question. That code would be in _physics_process or wherever you are doing the movement.