Rabbits vs Marblez- WIP Tower Defense Game Demo for feedback: Page 4

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

Rabbits vs Marblez- WIP Tower Defense Game Demo for feedback

xyz

It's probably browser settings or gpu per-application settings that limits it.

Btw preload shouldn't really be a problem. Calling it multiple times will just return a reference to the object. Resource itself is already loaded. No repeated loading is done. It's an inexpensive call.

My suspicion is that set_material() causes shader recompilation which is extremely expensive. I had a similar problem not so long ago. Even doing it sporadically may cause stutter.

So I'd also consider some of @cybereality's suggestions on having all marble versions prepared and just swapping them when downgrade needs to happen. Creating a new instance may be less expensive than the material change. Maybe try to run the profiler and see if material change causes any spikes in frame duration.

cybereality

@xyz said: You shouldn't be calling set_material() every frame. Call it only when material actually needs to be changed.

LOL. I totally missed that. Definitely not a good idea.

Erich_L

            if mylife==9:
                $CSGSphere.set_material(Global.blue_material)
            if mylife==5:
                $CSGSphere.set_material(Global.green_material)
            if mylife==3:
                $CSGSphere.set_material(Global.red_material)
            if mylife==1:
                $CSGSphere.set_material(Global.yellow_material)

This looks like a good place to use a switch case statement.

Megalomaniak

@Erich_L said:

            if mylife==9:
                $CSGSphere.set_material(Global.blue_material)
            if mylife==5:
                $CSGSphere.set_material(Global.green_material)
            if mylife==3:
                $CSGSphere.set_material(Global.red_material)
            if mylife==1:
                $CSGSphere.set_material(Global.yellow_material)

This looks like a good place to use a switch case statement.

IIRC match in godot/gdscript(switch equivalent) is a bit slower than if statements.

cybereality

@Megalomaniak said: IIRC match in godot/gdscript(switch equivalent) is a bit slower than if statements.

Yes, I've heard it's slower than if/elif. But in this case all 4 if statements are being checked every time, in which case I think a match would be faster. In any case, the difference is not huge, and the benefits to code clarity and avoidance of bugs would be beneficial.

xyz

The difference is probably negligible. Tbh I'd use a dictionary lookup. This is likely even slower than match, but again only marginally. However it'd produce the least amount of code and would scale well without any need for additional code and performance cost... But this is all nitpicking... the massive bottleneck was elsewhere anyway :)

jbskaggs

@xyz said: The difference is probably negligible. Tbh I'd use a dictionary lookup. This is likely even slower than match, but again only marginally. However it'd produce the least amount of code and would scale well without any need for additional code and performance cost... But this is all nitpicking... the massive bottleneck was elsewhere anyway :)

The bottleneck is probably the coder ;)

jbskaggs

Ok so I rewrote this little script with the match statement as a func. I think it reads better.

extends Spatial


var mylife=Global.enemy_health
var myname=Global.enemy_my_name


# Called when the node enters the scene tree for the first time.

func _ready():
	changetexture()

	
func changetexture():
	match mylife: 
				
		1:  
			$CSGSphere.set_material(Global.yellow_material) 
		3:	
			$CSGSphere.set_material(Global.red_material)
		5:
			$CSGSphere.set_material(Global.green_material)
		9:	
			$CSGSphere.set_material(Global.blue_material)

# Note for me: another way of doing this is with if statements:
#		if myname=="color_marble": #and myname!="robot_marble":
#			if mylife==9:
#				$CSGSphere.set_material(Global.blue_material)
#			if mylife==5:
#				$CSGSphere.set_material(Global.green_material)
#			if mylife==3:
#				$CSGSphere.set_material(Global.red_material)
#			if mylife==1:
#				$CSGSphere.set_material(Global.yellow_material)
#   etc...




func _on_Enemy_Area_area_entered(area):
	area.get_name()

	#check if touching goal
	if area.name=='EndGoal':
		print(Global.player_lives)
		Global.player_lives-=1
		get_parent().get_parent().queue_free()
		queue_free()
	
	#collision with bullet		
	if area.name=='bullet':
		Global.current_gold+=5
		mylife-=1	
		changetexture()
  		if mylife<=0:
			get_parent().get_parent().queue_free()

OpinionatedGamer

@jbskaggs said:

@xyz said: The difference is probably negligible. Tbh I'd use a dictionary lookup. This is likely even slower than match, but again only marginally. However it'd produce the least amount of code and would scale well without any need for additional code and performance cost... But this is all nitpicking... the massive bottleneck was elsewhere anyway :)

The bottleneck is probably the coder ;)

I was about to say something like "Come on, be nice," but then I realized the coder posted this. I need to keep up.

xyz

@jbskaggs Just watch out as the previous code will work properly only if damage decrement is always 1. It'll not behave once you introduce Elite Enforcer Hares that deal 2 damage. Something more robust may look like:

var material_by_hitpoints={
	8: Global.material_C,
	3: Global.material_B,
	1: Global.material_A,	
} 
# any number of threshold values  can be added in above dict
# as long as they are kept in descending order

func set_material_for_hitpoints(hitpoints): #call whenever hitpoints change
	var mat = material_by_hitpoints.values()[-1]
	for hp_threshold in material_by_hitpoints:
		if hitpoints >= hp_threshold:
			mat = material_by_hitpoints[hp_threshold]
			break
	set_material(mat)

jbskaggs

Thanks! This makes sense

jbskaggs

Today I I added the robot marble and I am working on jelly marble getting added well as some FX added. I should have them ready for upload later tonight or morrow. Trying to solve a problem with my jelly marble. I should be able to get most my marbles finished in next day or so.

On my towers- I have been toying with having a small city as my upgrade center. Different buildings unlock different characters. The issue with that is a deign issue my brain is struggling on how to make that look the best. Originally I wanted to have a 2d platform style Rabbit Warren or Dungeon - then I looked at top down similar to my tower defense maps. I personally think the Rabbit warren (though they are advanced sci fi) would be cool.

jbskaggs

Working on adding jelly's attack on shooter. I am not finding the problem. it chooses what looks like the farthest tower and the same one everytime.

func jelly_look_at():
	#convert enemies to towers
	
	var towers = get_tree().get_nodes_in_group("towers")
	
	# assume the first spawn node is closest
	if towers.size()>0:
	
		nearest_tower = towers[0]
		
		#run through enemies array to see which enemy is closest
		for tower in towers:
			if tower.translation.distance_to(translation) < nearest_tower.translation.distance_to(transform.origin):
				nearest_tower = tower
				var value= nearest_tower.translation.distance_to(translation)
		look_at(nearest_tower.translation, Vector3.UP)
		jelly_shoot()

func _process(delta):
		if myname=="jelly_marble":
			jelly_look_at()

cybereality

This line, you have to use the same calculation for both values:

if tower.translation.distance_to(translation) < nearest_tower.translation.distance_to(transform.origin):

So do this instead:

if tower.translation.distance_to(translation) < nearest_tower.translation.distance_to(translation):

Erich_L

@Megalomaniak said: IIRC match in godot/gdscript(switch equivalent) is a bit slower than if statements.

That seems really good to know thanks.

jbskaggs

@cybereality said: This line, you have to use the same calculation for both values:
if tower.translation.distance_to(translation) < nearest_tower.translation.distance_to(transform.origin):
So do this instead:
if tower.translation.distance_to(translation) < nearest_tower.translation.distance_to(translation):

Thank you I had already changed that just before I saw your message this morning. It had no effect. It still only shoots slime on one tower I can't tell how it chooses which tower. Somehow the nearest_tower is not the nearest tower.

So I edit this code to this to see which tower it would delete:

func jelly_shoot():
		timer +=1
		if timer==10:
			var newslime=Global.slime.instance()
			newslime.add_to_group("slime")
			newslime.global_transform = nearest_tower.global_transform
			get_tree().current_scene.add_child(newslime)
			nearest_tower.queue_free() #added this line to see which tower it would delete and it deleted them in order they were placed
			timer=0

xyz

Your current nearest tower code will work properly only if jellies and towers are in the same space, i.e. they are direct children of the same parent. If they are in different spaces you'll need to transform one into another's space before checking distances, or do the distance check in global space.

jbskaggs

@xyz said: Your current nearest tower code will work properly only if jellies and towers are in the same space, i.e. they are direct children of the same parent. If they are in different spaces you'll need to transform one into another's space before checking distances, or do the distance check in global space.

Ah- well I need to learn about "spaces" then. Makes sense though

xyz

For start you can try with checking distances this way:

var jelly_global = to_global(Vector3.ZERO)
var neatest_tower = towers[0]
for tower in towers:
	var tower_global = tower.to_global(Vector3.ZERO)
	var nearest_tower_global = nearest_tower.to_global(Vector3.ZERO)
	if jelly_global.distance_to(tower_global) < jelly_global.distance_to(nearest_tower_global):
		nearest_tower = tower

jbskaggs

@xyz said: For start you can try with checking distances this way:

var jelly_global = to_global(Vector3.ZERO)
var neatest_tower = towers[0]
for tower in towers:
	var tower_global = tower.to_global(Vector3.ZERO)
	var nearest_tower_global = nearest_tower.to_global(Vector3.ZERO)
	if jelly_global.distance_to(tower_global) < jelly_global.distance_to(nearest_tower_global):
		nearest_tower = tower

Ok my cancer brain is misfiring. Vector3.ZERO means what exactly? (0,0,0)?

« Previous Page Next Page »