Need help with movement, character moves up slight when moving left and right.

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

Need help with movement, character moves up slight when moving left and right.

VelvetRemedy

Whenever I move left or right in game, the char moves slight upward until I stop moving. here is the code:

extends KinematicBody2D

const ACCELERATION = 800
const MAX_SPEED = 75
var velocity = Vector2.ZERO
var gravity = 1000
var max_fall_speed = 100
var jump_force = -120
var jump_hold = 0.25
var local_hold = 0
onready var sprite = $Playerx32

func _physics_process(delta):
	var direction = sign(Input.get_action_strength("ui_right") - Input.get_action_strength("ui_left"))
	var jumping = Input.is_action_pressed("jump")
	var on_ground = velocity.y == 0
	if on_ground && jumping:
		velocity.y = jump_force
		local_hold = jump_hold
	elif local_hold > 0:
		if jumping:
			velocity.y = jump_force
		else:
			local_hold = 0
	
	local_hold -= delta
	
	if direction > 0:
		sprite.flip_h = false
		$CollisionPolygon2D.scale.x = 0.8
	elif direction < 0:
		sprite.flip_h = true
		$CollisionPolygon2D.scale.x = -0.8
	
	velocity.x = int(move_toward(velocity.x, MAX_SPEED * direction, ACCELERATION * delta))
	velocity.y = int(move_toward(velocity.y, max_fall_speed, gravity * delta))
	
	velocity = move_and_slide(velocity)

VelvetRemedy

Here is a video showing it happening:

cybereality

So this line can be replaced with a built-in function:

var on_ground = is_on_floor()

These two lines should probably not be cast as int:

velocity.x = move_toward(velocity.x, MAX_SPEED * direction, ACCELERATION * delta)
velocity.y = move_toward(velocity.y, max_fall_speed, gravity * delta)

If you need pixel movement, enable GPU Pixel Snap in the Project Settings.

VelvetRemedy

@cybereality Neither of those seemed to fix it, thank you for trying.

cybereality

It might be a problem with the collision mesh. Typically it is better to use rectangles (or circles) as complex collision polygons can have weird behavior.

VelvetRemedy

@cybereality I also asked on Reddit and someone suggested to only apply gravity when not on the ground, and that fixed it. After doing that however, it was jittery when on the ground and colliding with a wall, so I added when not on walls to the gravity if statement, like this:

velocity.x = int(move_toward(velocity.x, MAX_SPEED * direction, ACCELERATION * delta))
	if !is_on_floor() && !is_on_wall():
		velocity.y = int(move_toward(velocity.y, max_fall_speed, gravity * delta))

But now I can't jump when touching a wall on the ground, what should I do?

VelvetRemedy

People on Reddit found out why, can read about it here: https://www.reddit.com/r/godot/comments/tbkauq/char_moves_up_slightly_when_moving_left_and_right/