Audio Effect instances have no multithreading protection

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

Audio Effect instances have no multithreading protection

darthLevi

I have looked into the code of audio effect instances. none of them seem to have any kind of multithreading protection.
it could be that they have "worked" for now because the situation for them to malfunction didn't arise. however this is a concern to me.
does anyone know more about this?
I think AudioEffectInstance and AudioEffect should enforce the use of some mutexes.

TwistedTwigleg

I don’t know very much about the audio workings of Godot, but I’ve never had multithreading issues with it (though I rarely write multithreaded code…)

If you want to learn more about it, you might want to ask on the Godot Community chat and see if anyone there knows. I think there is a room/channel just for audio discussions, and the people there probably would know more about the audio system and whether it not having multithreading protection is an issue or not.

Megalomaniak

For the most part, in most projects and I mean like 99%+ of them there is likely no need to do any manual multi-processing or multi-threading for the audio. I think each server in godot already allocates it's own thread or process as it is which should mean the AudioServer also spawns it's own. I'd really question if it's absolutely necessary for your project to do any further multi-threading on that front. But of course I'm not familiar with your project or it's needs.