Sate of machines (or moving a player in English)

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

Sate of machines (or moving a player in English)

nitrogamestudios

The code works fine in theses steps: in the scene, the player is idle state when I pressing the left and right works too. The problem When I dont touch the keys is still walking, so dont clear the last state and do not set back the initial state which is idle state

here is

extends KinematicBody2D

const SPEED = 108 
var motion = Vector2()
onready var animation = $AnimationPlayer
func ready():
animation.play("idle")
func _physics_process(delta): 
	if Input.is_action_pressed("UI_RIGHT") or
        Input.is_action_pressed("UI_LEFT"):
		motion = move_and_slide(motion)
	else:
		motion = Vector2()

func _process(delta):
	var right = Input.is_action_pressed("UI_RIGHT")  
	var left = Input.is_action_pressed("UI_LEFT")
	if right: 
		$Sprite.flip_h = false
		animation.play("right")
		motion.x = SPEED
	elif left:
		$Sprite.flip_h = true
		animation.play("left")
		motion.x = -SPEED
	else:
		animation.play("idle") 
		motion.x = 0

Megalomaniak

try something like:

func _process(delta):
	var right = Input.is_action_pressed("UI_RIGHT")  
	var left = Input.is_action_pressed("UI_LEFT")
	if right: 
		$Sprite.flip_h = false
		animation.play("right")
		motion.x = SPEED
	
	if left:
		$Sprite.flip_h = true
		animation.play("left")
		motion.x = -SPEED
	
	if not right or not left:
		animation.play("idle") 
		motion.x = 0

You could also try using match instead of an if-else branching pattern but while that can help make some branching code simpler it's also a bit more complex pattern to understand as a new user. Match is godots equivalent to a switch statement.

SnapCracklins

@nitrogamestudios if/else can be tricky on animations. if you don't want to do a state machine, you may want to make a function, put it in the physics process and check if the button was released.

### slap this into physics process ###
func _idle():
       if Input.is_action_just_released("UI_LEFT") or Input.is_action_just_released("UI_RIGHT") : 
             motion.x = 0