Crouching collision shape change pushing player off edge

This is a READ-ONLY snapshot of the Godot Community Forums when TwistedTwigleg was the owner, which is hosted for archival reasons only. The current Godot Community Forums can be found here.

Some links may point to external websites, including the current Godot Community Forums. These websites are not associated with TwistedTwigleg.

Crouching collision shape change pushing player off edge

Lethn

I followed Garbaj's crouching tutorial awhile back and have had something of a basic FPS controller setup but I wanted to fix some things that were going on with it. I like that I can crouch jump with this because it makes the movement feel like the old vent crawling games like half life among other things. I've encountered something of a glitch though, because the method uses a clamp to change the height of the collision shape height if you let go of the crouch button near a ledge the player is pushed off as it goes back to the default height because the shape is pushing through the floor nudging the player off as a result.

What's the correct way to deal with this problem? The code works fine otherwise.

	if Input.is_action_pressed("Crouch"):
		isCrouching = true
		playerCollisionShape.shape.height -= crouchingSpeed * delta
		speed = crouchMoveSpeed
		playerCollisionShape.shape.height = clamp(playerCollisionShape.shape.height, crouchHeight, defaultHeight)
	elif raycastCeilingCheck.is_colliding() and isCrouching == true:
		isCrouching = true
		playerCollisionShape.shape.height -= crouchingSpeed * delta
		playerCollisionShape.shape.height = clamp(playerCollisionShape.shape.height, crouchHeight, defaultHeight)
		speed = crouchMoveSpeed
	elif not raycastCeilingCheck.is_colliding() and isCrouching == true:
		isCrouching = false
		playerCollisionShape.shape.height += crouchingSpeed * delta
		playerCollisionShape.shape.height = clamp(playerCollisionShape.shape.height, defaultHeight, crouchHeight)
		speed = crouchMoveSpeed

Lethn

If this can be done in Godot it would be very useful for fixing my problem, can I change the height from one specific direction? So as an example rather changing the height both directions on the Y axis change it on one direction?

Megalomaniak

You'd normally have multiple collision shapes and just switch which one is enabled if you need to change between different collision shape sizes.

Lethn

I guess I'll have to experiment more with that method then and maybe just move the camera's transform.origin between points.

Lethn

Oh! I've got it! With more tweaking I can make it accurate, I could potentially shrink the width now of the collision shape among other things and it's also working more as expected, I was having issues getting this method to work and hadn't realised there was a minor bug involving disabling and enabling colliders. People posted online that call deferred worked best so that's something to remember.

Thanks for the tips, they pointed me in the right direction.

	if Input.is_action_pressed("Crouch"):
		isCrouching = true
		playerCollisionShape.set_deferred(("disabled"), false)
		playerCrouchingCollisionShape.set_deferred(("disabled"), true)
		speed = crouchMoveSpeed
	elif raycastCeilingCheck.is_colliding() and isCrouching == true:
		isCrouching = true
		playerCollisionShape.set_deferred(("disabled"), false)
		playerCrouchingCollisionShape.set_deferred(("disabled"), true)
		speed = crouchMoveSpeed
	elif not raycastCeilingCheck.is_colliding() and isCrouching == true:
		isCrouching = false
		playerCollisionShape.set_deferred(("disabled"), true)
		playerCrouchingCollisionShape.set_deferred(("disabled"), false)
		speed = defaultMoveSpeed

My only gripe with this method is it seems to be being fussy somehow about height, however I think with more setup tweaking that can be fixed, for vent crawling it might be more of a scaling issue I need mess with.